Fix/Multiple UI Issues #587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #587 +/- ##
========================================
Coverage 61.81% 61.81%
========================================
Files 22 22
Lines 1485 1485
========================================
Hits 918 918
Misses 567 567
Continue to review full report at Codecov.
|
RTS340
approved these changes
Dec 10, 2019
|
@j4v yes these are still TODOs. Will look in to them more next week |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed some login in ScoutSuite.js to stop the UI thinking it needed to load render the data several times.
Fixed two rules that were breaking the UI as they don't display anything.
This will fix #584 and #378