Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve AWS findings (rationale+references) #711

Merged
merged 1 commit into from Apr 9, 2020

Conversation

ramimac
Copy link
Contributor

@ramimac ramimac commented Apr 9, 2020

Description

I went through and added rationale and references to as many AWS findings as I could.
Ran the format_findings.py tool after

Type of change

Select the relevant option(s):

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works (optional)
  • New and existing unit tests pass locally with my changes

@x4v13r64 x4v13r64 merged commit e1f4174 into develop Apr 9, 2020
@x4v13r64 x4v13r64 deleted the enhancement/aws-findings-format branch April 9, 2020 18:24
@x4v13r64
Copy link
Collaborator

x4v13r64 commented Apr 9, 2020

It's grunt work but someone's got to do it!

Between this PR and #679, AWS findings' content will be very much improved.

@ramimac
Copy link
Contributor Author

ramimac commented Apr 9, 2020

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants