Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show VPC ID instead of name when no name is available. Fixes #707 #725

Merged
merged 1 commit into from Apr 25, 2020

Conversation

alessandrogonzalez
Copy link
Collaborator

Description

The report was showing whitespaces in the left menu for VPC-based resources instead of VPC name. This happened when the --services option was used, as it was likely the name was not available as the VPC resource was not fetched.

The changes replace the VPC name with the VPC ID (which is accessible) when the name is not available.

Fixes #707

Type of change

Select the relevant option(s):

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works (optional)
  • New and existing unit tests pass locally with my changes

@alessandrogonzalez alessandrogonzalez linked an issue Apr 23, 2020 that may be closed by this pull request
@x4v13r64 x4v13r64 merged commit 97e80ef into develop Apr 25, 2020
@x4v13r64 x4v13r64 deleted the bugfix/707-whitespace-vpc-resources branch April 25, 2020 08:44
@x4v13r64
Copy link
Collaborator

🎖️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Report includes whitespace for AWS VPC resources
3 participants