Incorrect HTML for VPC Network ACLs #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
x4v13r64
approved these changes
Jan 15, 2019
misg
approved these changes
Jan 15, 2019
vifor2
approved these changes
Jan 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a temporary fix for the missing instances under network>network acls>subnet and incidentally fixes a bunch of broken links and missing info in modals in general (#6 ).
What the fix does is it adds the ids inferred from the resource path to the partial template's context. For example, the path
services.vpc.vpcs.vpc-id.regions.region-id.subnets.subnet-idadds the following attributes to the context:This way, the partial template can access info relative to its instance.
I acknowledge this fix is not ideal, but it seems like a legit fix would require refactoring the whole modal system, or the resource management system.