Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-account, py3, no-tk #18

Closed
wants to merge 5 commits into from
Closed

Multi-account, py3, no-tk #18

wants to merge 5 commits into from

Conversation

t-rojan
Copy link

@t-rojan t-rojan commented Dec 9, 2018

Hi - This fork has the following changes;

  1. supports capturing inventory from multiple accounts at once
  2. converted to python 3
  3. removed tk, replaced with a text progress bar (and no prompts to start in the interests of Nice work! #1)
  4. added option to enable/disable output formats (gui/data etc)

1. converted to python 3
2. added --regex option to enable executing over multiple
accounts/profiles
3. removed Tk, replaced with tqdm and no prompts
@seren
Copy link

seren commented May 19, 2020

These changes would be nice to have merged (especially py3 support now that py2 is deprecated).

@ramimac ramimac self-assigned this Aug 29, 2020
@ncc-erik-steringer ncc-erik-steringer self-assigned this Sep 6, 2020
@ncc-erik-steringer
Copy link
Collaborator

ncc-erik-steringer commented Sep 7, 2020

Sorry that we haven't been able to respond to everyone at a faster rate. I've implemented pretty much everything in this request on a separate branch, develop: https://github.com/nccgroup/aws-inventory/tree/develop . It defaults to the new "cmd" display mode, but retains the old "gui" mode.

Closing this in the meantime. Thank you for your contributions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants