Fix Issue #72 #74
Merged
Fix Issue #72 #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[PEP440] requires that versions be in the form:
[N!]N(.N)*[{a|b|rc}N][.postN][.devN]
Local version identifiers are also supported:
<public version identifier>[+<local version label>]
My use of dashes violates this. However, I'd prefer that the setup.py
still work in light of such mistakes. The updated regex supports
".", "-", and "+". The match for both .postN.devN together is also
included.
Ensuring strict compliance to the versioning that will be enforced
by PyPi is something should be enforced via unit tests or CI. Opened
issue nccgroup#73 to track this.
[PEP440]: https://www.python.org/dev/peps/pep-0440/#public-version-identifiers
The upcoming fixes for nccgroup#23 and nccgroup#24 require API additions that necessitate a minor version increment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses version check regex issue in setup.py and bumps to 0.3.0.dev0.