Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI improvement - Bootstrap version and highlights #59

Closed
x4v13r64 opened this issue Dec 14, 2018 · 4 comments
Closed

UI improvement - Bootstrap version and highlights #59

x4v13r64 opened this issue Dec 14, 2018 · 4 comments
Assignees
Labels
component-UI Affects UI enhancement New feature or request
Projects
Milestone

Comments

@x4v13r64
Copy link
Collaborator

x4v13r64 commented Dec 14, 2018

  • Update Bootstrap to 4.1.3 (currently uses 3.0.3)
  • Update jQuery to 3.3.1 (currently uses 1.11.2)

Use Bootstrap colors for titles (https://getbootstrap.com/docs/4.0/utilities/colors/). This is especially important as text-on-titles doesn't show very well:
sc_2018-12-14_15h26m44s

@x4v13r64 x4v13r64 added enhancement New feature or request component-UI Affects UI labels Dec 14, 2018
@x4v13r64 x4v13r64 changed the title UI Bootstrap improvements UI improvement - Bootstrap version and highlights Dec 18, 2018
@x4v13r64 x4v13r64 added this to the Milestone 2 milestone Dec 21, 2018
@Aboisier Aboisier added this to To do in Scout Suite Jan 15, 2019
@x4v13r64 x4v13r64 modified the milestones: Milestone 2, Milestone 1 Jan 16, 2019
@vifor2 vifor2 self-assigned this Jan 16, 2019
@vifor2 vifor2 added this to To Do in Scout Suite Jan 17, 2019
@vifor2 vifor2 moved this from To Do to In progress in Scout Suite Jan 17, 2019
@vifor2
Copy link
Contributor

vifor2 commented Jan 22, 2019

This is proving to be much longer/tedious than I expected, still WIP.

@x4v13r64
Copy link
Collaborator Author

Yep, it may not be as easy as it seems:

  • Upgrading BS probably breaks the theme. If it's a valid solution you could swap the themes for pre-made light/dark themes (e.g. https://bootswatch.com/).
  • In the current UI architecture, the label's class is used for drawing & logic. This is really messy and shouldn't be the case, so using proper BS success/warning/danger labels will probably involve decoupling these two elements.

@vifor2
Copy link
Contributor

vifor2 commented Jan 22, 2019

Yes Iv'e already upgraded the themes, but haven't applied your second point yet, thank you for the suggestions 👍 .

The main issue with upgrading Bootstrap is that the current classes used for styling either no longer exist, have been renamed or have different properties, therefore it's what I am currently adjusting and it's starting to look more like what it is supposed to look like!

One annoyance that I haven't managed to fix yet is the collapsible sub-menu, on the current version on develop it expands towards the bottom of the navbar, while on my version it expands on the right. Still searching for a way to force it to expand towards the bottom without having to change the structure in the .html.

Before expanding :
image

After expanding :
image

@vifor2 vifor2 closed this as completed Jan 25, 2019
Scout Suite automation moved this from In progress to Done Jan 25, 2019
@x4v13r64
Copy link
Collaborator Author

@vifor2 has the "Bootstrap colors for titles" been implemented, or are you moving this to a separate issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component-UI Affects UI enhancement New feature or request
Projects
No open projects
Scout Suite
  
Done
Development

No branches or pull requests

2 participants