Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Sobelow.SQL.Query to test for both query() and query!(), similar to Sobelow.Traversal.FileModule (#153) #155

Merged
merged 3 commits into from
Feb 11, 2024

Conversation

iarekk
Copy link
Contributor

@iarekk iarekk commented Feb 10, 2024

Add support for both query() and query!() in the Sobelow.SQL.Query module.

This fixes #153.

Going with the Option 2 suggested by @houllette:

Change the functionality of the entire detection to be more similar to that of something like our File traversal rule which supports detecting a plethora of sub-

This is probably the more accurate approach to better support long term if more similar functions are discovered needing support. e.g. query_many

@houllette houllette merged commit c755ba7 into nccgroup:master Feb 11, 2024
9 checks passed
@iarekk iarekk deleted the sql_with_a_bang branch February 12, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Misses vector if function contains bang operator (!)
2 participants