Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable https check in runtime #162

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

alvarezloaiciga
Copy link

This fixes an issue with new phoenix projects moving away from prod.exs to runtime.exs

@houllette
Copy link
Collaborator

This is a great PR, thanks @alvarezloaiciga and sorry for the delay in evaluating it! Just a quick note that we should probably figure out before merging this in - so as pointed out by #166, force_ssl being in runtime.exs won't work since it is exclusively a compile time config. The latest changes in #166 actual move towards excluding HSTS checks for the runtime.exs file; so obviously we should still check for all the other HTTPS configs in runtime, but we don't need to worry about force_ssl. So it may make sense to change the values found in the runtime.exs test case you have here 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants