Move fetch from content to background, fixes #91 #92

for-indy · 2019-04-02T21:46:29Z

No description provided.

heathj

If you can make the following edits, this would be perfect. Also, I didn't ask, but I assume this fixes the bug, right?

plugin/scripts/highlight.js

for-indy · 2019-04-03T17:05:08Z

If you can make the following edits, this would be perfect. Also, I didn't ask, but I assume this fixes the bug, right?

Yes, the payload is retrieved and inserted into the page now, no more CORB error.

Move fetch from content to background, fixes nccgroup#91

3e08c25

for-indy force-pushed the master branch 2 times, most recently from e89258b to 3e08c25 Compare April 2, 2019 23:20

heathj requested changes Apr 3, 2019

View reviewed changes

plugin/scripts/highlight.js Outdated Show resolved Hide resolved

plugin/scripts/highlight.js Outdated Show resolved Hide resolved

Remove conf as confi is all in background page

462f022

for-indy force-pushed the master branch from 0afe5f7 to 462f022 Compare April 3, 2019 17:06

heathj self-requested a review April 3, 2019 20:17

heathj approved these changes Apr 3, 2019

View reviewed changes

heathj merged commit 3393078 into nccgroup:master Apr 3, 2019

Provide feedback