Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug causing parser error in front which needs looking at #49

Closed
olliencc opened this issue Mar 12, 2014 · 3 comments
Closed

Bug causing parser error in front which needs looking at #49

olliencc opened this issue Mar 12, 2014 · 3 comments
Labels

Comments

@olliencc
Copy link
Contributor

when doing certain domains with all the generation options on seeing a couple of errors which I had to handle a fail condition for to allow the front end UI to complete. Need to investigate when I get time.

@olliencc olliencc added the bug label Mar 12, 2014
@olliencc
Copy link
Contributor Author

this this is in the back end. With the new logging now seeing this in the front end:

Error parsererror SyntaxError: Unexpected end of input

@neonbunny
Copy link
Member

This is subtle and has taken a lot of tracking down as there's not an exception in sight... It appears to be caused because the backend sends the HTTP success headers before calculating the response. If the response calculation takes too long, then the web browser assumes the response is complete, and passes the still empty response body to the javascript.

neonbunny added a commit to neonbunny/typofinder that referenced this issue Mar 22, 2014
…r flow control which could have caused exceptions being wrongly swallowed
olliencc pushed a commit that referenced this issue Mar 23, 2014
Fix for #49 and removed more exception handling being used for flow control
@olliencc
Copy link
Contributor Author

Looks fixed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants