removed Manager class metaclass and modified operation lookup to __ge… #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
these are existing failures from the UT. |
|
@siming85, this PR is now out of date with respect to the master branch. Can you please bring it up to date with the master branch? Cheers, Einar |
einarnn
added
the
Waiting
|
merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OpExecutor metaclass's only functionality was to "patch" in vendor/standard operations.
using a metaclass to patch it in totally ignores the fact that Manager() class can be subclassed and subsequent operations (eg, get) modified through subclass methods.
this fixes it to use getattr to do a lookup if-and-only-if the operation isn't defined.