Fix junos confirm-commit issue and check mode issue #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes ncclient#238 * As per Juniper documentation the correct xml tag for commit rpc is `commit-configuration` and not `commit`. * Add support for `check` mode Before in case commit is not issued after confirm commit. Device logs show rollback happens immediately ``` user@junos# show | compare rollback ? Possible completions: 0 2018-06-14 04:59:12 UTC by junos via netconf 1 2018-06-14 04:59:07 UTC by junos via netconf commit confirmed, rollback in 0mins ``` After the patch in this PR is applied ``` [edit] Broadcast Message from user@junos (no tty) at 5:41 UTC... Commit was not confirmed; automatic rollback complete. user@junos# show | compare rollback ? Possible completions: 0 2018-06-14 05:41:40 UTC by root via other 1 2018-06-14 05:39:39 UTC by user via netconf commit confirmed, rollback in 2mins ```
einarnn
approved these changes
Jun 16, 2018
stephanerobert
pushed a commit
to stephanerobert/fake-switches
that referenced
this pull request
Aug 17, 2018
Updating dependencies caused some xml to fail. Needed to change commit to commit-configuration because of: ncclient/ncclient#239
stephanerobert
pushed a commit
to stephanerobert/fake-switches
that referenced
this pull request
Aug 29, 2018
Updating dependencies caused some xml to fail. Needed to change commit to commit-configuration because of: ncclient/ncclient#239
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #238
is
commit-configurationand notcommit.checkmodeBefore in case commit is not issued after confirm commit.
Device logs show rollback happens immediately
After the patch in this PR is applied