Avoid spurious SessionCloseError when intentionally closing session. #268
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed that when sending a CloseSession RPC, which calls session.
close()
, ncclient still logs a debug aboutSessionCloseError("Unexpected session close")
and callsclose()
a second time.Solution: Add a
_closing
event and set its flag whenclose()
has been called already; if thread detects that the session is closed and this flag is set, treat it as a graceful exit rather than raising an exception.