Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First draft of versioning with versioneer #269

Merged
merged 5 commits into from
Aug 20, 2018
Merged

First draft of versioning with versioneer #269

merged 5 commits into from
Aug 20, 2018

Conversation

einarnn
Copy link
Contributor

@einarnn einarnn commented Aug 20, 2018

Installation of versioneerinto source tree to allow for PyPi versions to be directly derived from git tags based on format vX.Y.Z.

@einarnn einarnn self-assigned this Aug 20, 2018
@coveralls
Copy link

Coverage Status

Coverage decreased (-3.1%) to 65.951% when pulling c172077 on versioneer into 8ef20f2 on master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage decreased (-3.1%) to 65.951% when pulling c172077 on versioneer into 8ef20f2 on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-3.1%) to 65.951% when pulling c172077 on versioneer into 8ef20f2 on master.

@coveralls
Copy link

coveralls commented Aug 20, 2018

Coverage Status

Coverage decreased (-3.04%) to 65.867% when pulling 4bedcf2 on versioneer into 5ae34e2 on master.

setup.cfg Outdated

[versioneer]
VCS = git
style = git-describe

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that this produces a non-PEP440-compliant version string for non-release versions:

$ python setup.py --version
python3.5/site-packages/setuptools/dist.py:407: UserWarning: The version specified ('0.6.0-22-gc172077') is an invalid version, this may not work as expected with newer versions of setuptools, pip, and PyPI. Please see PEP 440 for more details.
  "details." % self.metadata.version
0.6.0-22-gc172077

Personally I prefer pep440-pre style (0.6.0.post0.dev22) but the basic pep440 style (0.6.0+22.gc172077) is closer to git-describe style; either one makes setuptools happier.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed to pep440.

Copy link

@glennmatthews glennmatthews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a big fan of versioneer; go for it!

@einarnn einarnn merged commit bce973e into master Aug 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants