Fix/additions around hostkey validation #278
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
rdkls
commented
Sep 8, 2018
rdkls
commented
- Fix for hostkey checking on nonstandard ssh ports
- Move server_key and fingerprint calculation into 'if hostkey_verify' block, since we only need them there
- Add ability to verify remote host against specific hostkey
- Move server_key and fingerprint calculation into 'if hostkey_verify' block, since we only need them there - SSH transport connect() add parameter 'hostkey' for ability to verify remote host against that specific hostkey - Update docs/transport.rst accordingly
einarnn
requested changes
Sep 9, 2018
| raise e | ||
| # Add the supplied hostkey to my host_keys, to be used in the following .check() | ||
| # key_object.get_name() is actually the key type e.g. 'ssh-rsa' | ||
| self._host_keys.add(host, key_object.get_name(), key_object) |
There was a problem hiding this comment.
One of the checkin comments says "Add ability to verify remote host against specific hostkey", but the way the code is written means that the provided hostkey will be added to any existing hostkeys? Is that the intent?
There was a problem hiding this comment.
Correct - will change thanks
| @@ -19,6 +19,11 @@ def test_connect_ssh(self, mock_ssh): | |||
| manager.connect(host='host') | |||
| mock_ssh.assert_called_once_with(host='host') | |||
|
|
|||
| @patch('ncclient.manager.connect_ssh') | |||
There was a problem hiding this comment.
Could this test do more? Like verify a specific, real hostkey?
|
closing in favour of new PR with different approach |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.