Add Ciena driver

[jgroom33]

Also alphabetize the lists

[einarnn]

In general it's not clear to me what this device handler adds. A device handler is typically implemented if there is something special that is needed. For example, the IOS XE device handler adds a save_config operation:

https://github.com/ncclient/ncclient/blob/master/ncclient/devices/iosxe.py#L36-L39

This Ciena device handler doesn't seem to add any custom behaviour...?

[einarnn]

This has the effect of restricting what capabilities are offered by ncclient to a Ciena device. Is that your intention? If so, it is not actually necessary.

[jgroom33]

Thanks. I will remove.

[jgroom33]

No additional capabilities are required. The driver is necessary because the device does not support a namespace (nc) on the base namespace. So, this code is necessary:
def get_xml_base_namespace_dict(self):
return {None: BASE_NS_1_0}

I attempted to use the default driver and override the namespace of the root, but could not figure it out. It seems the implementation of this library in Ansible provides limited ability to override any methods until some driver is specified.

[jgroom33]

Several of the drivers in this repo seem to require the namespace modification.
As an alternative to creating another vendor specific driver, I think there should be another generic driver that only has the namespace modification.
Do you think this is a better approach?

[einarnn]

@jgroom33, apologies for long delay. Having a single base driver that allows a vendor-specific driver to add in just namespace modifications may make sense. But it probably should be a per-vendor class ultimately as non-vendor engineers would likely not know what the vendor-specific namespace tweaks would need to be.

[jgroom33]

@einarnn

For reference, The following drivers implement the null namespace for BASE_NS_1_0:

• alu
• hpcomware
• ericsson
• huawei
• h3c
• sros
• huaweiyang

I'm not familiar with the other devices, but the only reason I opened this PR for the Ciena device is to null the BASE_NS_1_0 namespace. I suspect it might be similar for other vendors.

What I'm proposing is one of these options:

1. delete this PR. Open a new PR with a new driver Generic_BASE_NS_1_0 that handles the namespace nullify
2. delete this PR. update the generic driver so it nullifies BASE_NS_1_0
3. Merge this PR

What would be your preference? I'm good with any of the above.

[einarnn]

@jgroom33, sorry for delay. I will merge this PR.