Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update session.py #576

Merged
merged 2 commits into from
Dec 26, 2023
Merged

Update session.py #576

merged 2 commits into from
Dec 26, 2023

Conversation

iLaus
Copy link
Contributor

@iLaus iLaus commented Oct 17, 2023

            # for huawei fireworks, you need change NetconfBase.BASE_11, when you received device return.
            # in gevent , the function _post_connect's init_event.wait(timeout) can not work.
            # you can add gevent.sleep(0.1) before(or replace) init_event.wait(timeout) .
            # or change the order of the send and receive.
            # when you send first, the self._base woun't change NetconfBase.BASE_11.

                # for huawei fireworks, you need change NetconfBase.BASE_11, when you received device return.
                # in gevent , the function _post_connect's init_event.wait(timeout) can not work.
                # you can add gevent.sleep(0.1) before(or replace) init_event.wait(timeout) .
                # or change the order of the send and receive.
                # when you send first, the self._base woun't change NetconfBase.BASE_11.
@einarnn einarnn self-assigned this Oct 21, 2023
@einarnn einarnn self-requested a review October 21, 2023 09:29
@iLaus
Copy link
Contributor Author

iLaus commented Oct 25, 2023

How about my suggestion? @einarnn

Removed Huawei-specific comments.
@coveralls
Copy link

Coverage Status

coverage: 82.824% (+0.4%) from 82.468%
when pulling 6641f73 on iLaus:master
into f0f4d95 on ncclient:master.

@einarnn einarnn merged commit 9e947eb into ncclient:master Dec 26, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants