-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tqdm bar #481
Tqdm bar #481
Conversation
Codecov Report
@@ Coverage Diff @@
## master #481 +/- ##
==========================================
+ Coverage 76.98% 77.02% +0.03%
==========================================
Files 132 132
Lines 9407 9419 +12
==========================================
+ Hits 7242 7255 +13
+ Misses 2165 2164 -1
Continue to review full report at Codecov.
|
I tested this solution, and it has an issue when the optimization timeout is set: In this case, we have a near-infinite number of generations, since the evaluation time is limited by timeout, not the number of generations. However, I am not sure that tqdm supports the time limit feature or there is the simple way to estimate the real number of generations. So, the improvement can be conducted in other PR. P.S. For the next PR, i also have the idea to move the progress bar to OptimisationTimer to simplify the code. |
I noticed this, but as you say there is no simple way to estimate better than self.requirements.num_of_generations. One solution is to create a different bar for when a timeout is the cap rather than the generations, Would you like me to add those here or in a separate PR after this one has been closed? |
Yes, it would be great if you do it. |
@itay-raveh Thanks for the contribution! |
* Add tqdm progress bar around loops in optimise() * Add show_progress flag
#479
tqdm progress bars have been added to the generation iteration loop and the final output ind resotre loop in gp_optimiser and param_free_gp_optimiser