Now kubectl through https uses gce #5
Conversation
| PREFIX = gcr.io/google_containers | ||
| TAG = 1.2 | ||
| #PREFIX = gcr.io/google_containers | ||
| PREFIX = stevemilnerrh |
There was a problem hiding this comment.
TODO replace with gcr.io once the new version has been pushed
ashcrow
force-pushed
the
gce_use_netexec_for_spdy_e2e
branch
from
5fb8723
to
633d75b
Compare
| @@ -161,6 +165,7 @@ var _ = Describe("Kubectl client", func() { | |||
| It("should support exec", func() { | |||
| By("executing a command in the container") | |||
| execOutput := runKubectl("exec", fmt.Sprintf("--namespace=%v", ns), simplePodName, "echo", "running", "in", "container") | |||
|
|
|||
There was a problem hiding this comment.
I have found it to be more idiomatic to strike lines of this class in golang. You don't have to do it though.
There was a problem hiding this comment.
Whitespace is a friend, not an enemy
|
LGTM module those nits, this is ready to get some feedback from upstream on. |
ashcrow
force-pushed
the
gce_use_netexec_for_spdy_e2e
branch
from
633d75b
to
8b4fc05
Compare
|
We might want to have the new goproxy image be in a separate commit. WDYT @pmorie? |
|
@ncdc You're going to wind up squashing anyway once you have more commits to address feedback, don't worry about it for now. |
|
@pmorie well, it's not really about squashing. Right now there is 1 commit that adds e2es for exec+proxy and adds the goproxy image. I'm suggesting we split this 1 commit into 2. |
|
@ncdc I understand, and I'm saying that odds are you'll have feedback that cuts across all of it anyway that you'll want to capture in those same commits after you squash in new commits that contain the cross-cutting feedback. |
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. Remove redundant call to StartLogging in service_controller. Fixes #5… …4339 **What this PR does / why we need it**: Removes redundant call to StartLogging introduced in 96b48d4#diff-1f7f903e25ab8bcbc514bb1e532e997e **Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes # kubernetes#54339 **Special notes for your reviewer**: **Release note**: ```release-note ```
GCE spdy proxy e2e tests
This is a modification of #4 . The changes are the same but much of the internals have been updated to utilize
testContextinstead of environment variables, using SSL and tokens fornetexec'skubectlcalls, andunversioned.Clientfor proxying through the api server to pods. No new arguments have been added to thee2e.testbinary.Notes
Images
The
pods.yamlfor bothnetexecandgoproxyhave been temporarily changed to point to dockerhub where I have the test images posted.Running
This is called when running the e2e tests which insinuates that
kubectlwill be available on the system running the tests.---hostmust be $SCHEME$HOST:$PORT/api: https://127.0.0.1:443/api--kubectl-pathmust be a real path to the kubectl binary---kubeconfigmust be a valid kubeconfig with an e2e user that has a token