Example of syntax update #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ncharles
merged this pull request
into
ncharles:bug_3642/dev/create_migration_script_to_undot_all_variable_name
ncharles
added a commit
that referenced
this pull request
Dec 6, 2021
# This is the 1st commit message: Fixes #20310: Method getByRulesCompliance used by API is highly inefficient # The commit message #2 will be skipped: # fixup! Fixes #20310: Method getByRulesCompliance used by API is highly inefficient # # Fixes #20310: Method getByRulesCompliance used by API is highly inefficient
fanf
deleted the
bug_3642/dev/create_migration_script_to_undot_all_variable_name
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All the logic seems OK to me. But several times, I wondered what was happening because the logic structure was not apparent in the code. This is an example of indentation/spaces updates that show how you could better follow our coding convention and make the code understanding simplier.