Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

d should be self.dim in GenericRWHM #36

Closed
finncatling opened this issue Nov 13, 2021 · 1 comment
Closed

d should be self.dim in GenericRWHM #36

finncatling opened this issue Nov 13, 2021 · 1 comment

Comments

@finncatling
Copy link
Contributor

Thanks for this excellent library!

A bug crept into GenericRWHM in v0.3, where d was replaced (with self.dim) but then is still used later in the class despite now not being defined.
finncatling added a commit to finncatling/particles that referenced this issue Nov 14, 2021
@finncatling
d should be self.dim in GenericRWHM
446d95b 
Fixes nchopin#36
@finncatling finncatling mentioned this issue Nov 14, 2021
Closed
@finncatling finncatling mentioned this issue Nov 14, 2021
Merged
@nchopin
Copy link
Owner

nchopin commented Nov 22, 2021

Good catch, I always re-run all my scripts before I release a new version, but the scripts all use mcmc in a way that does not trigger this bug, so I missed it. Thanks a lot for spotting this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@finncatling @nchopin