Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User Story 1: tabs and spaces config per project #14

Open
paulvi opened this issue Sep 2, 2015 · 4 comments
Open

User Story 1: tabs and spaces config per project #14

paulvi opened this issue Sep 2, 2015 · 4 comments

Comments

@paulvi
Copy link

paulvi commented Sep 2, 2015

Story:

It is enough to put .editorconfig in the root of the project with

indent_style = value
indent_size = n

then files will look the same in any editor, and selection to use tabs or spaces will be preserved.
Eclipse workspace can have projects that have different configs.

When project does not have .editorconfig default settings per workspaces are used.

@paulvi
Copy link
Author

paulvi commented Sep 2, 2015

Discussion may become long, there is even not fitting idea of configuration for file extension or per Editor. EditorConfig also has idea of different config per folder (just because it is represented by file), but for most Editors that would be too much of complication to implement.

I see EditorConfig as promise to and tabs-vs-spaces by having universally excepted and clean specification for a project.

The main difficulty is having different acting values for different project, as Eclipse does not have such notion.

@ncjones
Copy link
Owner

ncjones commented Sep 2, 2015

I don't understand what this story is describing. Can you elaborate?

The way this plugin works currently is to change the global settings for all supported editors to match the editorconfig of the file being edited whenever any editor gains focus. There is no special treatment required for having different whitespace rules for different projects as this is handled by the core editorconfig library.

@paulvi
Copy link
Author

paulvi commented Sep 4, 2015

The story is what could be minimal use case. It is about solving tabs vs spaces war problem, instead of new feature of different settings per folder.

I just got understanding that Eclipse does not have per project settings, and that is an issue to Eclipse.

@ncjones
Copy link
Owner

ncjones commented Nov 17, 2015

I'm still not clear on the story but here are my thoughts:

  1. There are ways to share editorconfig settings between projects, primarily with .editorconfig in a shared ancestor but you could also do tricks with symlinks (I wouldn't though) so any additional handling of that scenario is out of scope for this plugin.
  2. Eclipse does support per project whitespace settings.
  3. This plugin does not handle well the scenario where the Eclipse workspace contains mixtures of projects with and without editorconfig files.

Is point 3 above what you are describing here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants