Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

auto cleanup the plugin process when it's not needed #1

Open
roxma opened this issue Jul 2, 2018 · 7 comments
Open

auto cleanup the plugin process when it's not needed #1

roxma opened this issue Jul 2, 2018 · 7 comments

Comments

@roxma
Copy link
Member

roxma commented Jul 2, 2018

roxma/nvim-completion-manager#215
roxma/nvim-completion-manager#62

@partounian
Copy link

I'm not able to replicate roxma/nvim-completion-manager#62, I tried to replicate it by removing the lines

# jedi doesn't work on comment
# https://github.com/roxma/nvim-completion-manager/issues/62
if typed.find('#') != -1:
    return

I used htop on my macOS version 10.13.5 and searched for jedi while looking at overall ram usage and it seemed to be the same.

python 3.7.0
nvim 0.3.0
ncm2 6e0dabf
ncm2-jedi 96f7658
jedi 0.12.1

Also haven't seen roxma/nvim-completion-manager#215 , I wonder if it's Windows specific?

Any more information would be lovely 😄

@roxma
Copy link
Member Author

roxma commented Jul 3, 2018

The memory issue is probably related to older python's memory leak.
https://www.python.org/dev/peps/pep-0442/

It is hard to reproduce and I haven't come across this issue for a long tmie.

Let's wait for more report on this issue before pushing changes.

@partounian
Copy link

Thoughts on deleting those lines and seeing if anyone has an issue with it?

@roxma
Copy link
Member Author

roxma commented Jul 5, 2018

hmm... I'm ok with thoes lines, they don't break anything yet.

@partounian
Copy link

Okay with removing, or you want to leave them in?

@roxma
Copy link
Member Author

roxma commented Jul 6, 2018

I think it's fine to keep them.

@roxma
Copy link
Member Author

roxma commented Jan 20, 2019

Now we have a case: #10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants