Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify the config syntax #18

Closed
ghost opened this issue Nov 10, 2014 · 5 comments
Closed

Unify the config syntax #18

ghost opened this issue Nov 10, 2014 · 5 comments

Comments

@ghost
Copy link

ghost commented Nov 10, 2014

Some things can be bolded and others can't, some colors can be set with 2_5 etc. and others require color names and thus can't have different background color.

Things like columns playlist and volume need bolding from the top of my head.
The playlist also needs to use the new fg_bg notation.

Changing the notation to red_green instead of 2_3 would probably help many people understand it.

@arybczak
Copy link
Collaborator

red_green can be used instead of 2_3. Also, if you can list all the inconsistent stuff in more details it would be great.

@ghost
Copy link
Author

ghost commented Nov 11, 2014

red_green can be used instead of 2_3

Then document it.
What's the use to have it if no one knows about it.

This is the most important one
The syntax between the header formating and column list formating should be even vaguely similiar or at least have same tags such as $b and $/b work everywhere.

Also the separator between the column names and the song list should have a colouring option and bolding too.

Volume indicator needs boldness option.

The Playing and [Paused] should be colored separately from the rest of the bar, as should the remaining time.

I think that covers most of it.

@arybczak
Copy link
Collaborator

Then document it.
What's the use to have it if no one knows about it.

Then RTFM? It's written in the example configuration file:

It is possible to set a background color by setting a color
value "<foreground>_<background>", e.g. red_black will set
foregound color to red and background color to black.

The syntax between the header formating and column list formating should be even vaguely similiar or at least have same tags such as $b and $/b work everywhere.

This was already done.

The problem with allowing other elements to be customizable (i.e. allowed to be bolded or not) is that if it's done naively, i.e. like with progressbar, it results in a shitton of configuration variables. And then someone will complain that there is no option for underline or reverse. That's why I'm thinking about changing the way the customization works for these parts, i.e. applying prefix/suffix formatting to them. This would solve all the possible problems.

Any thoughts?

@ghost
Copy link
Author

ghost commented Nov 11, 2014

Then RTFM? It's written in the example configuration file:

It is possible to set a background color by setting a color
value "_", e.g. red_black will set
foregound color to red and background color to black.

I can't believe I missed that.

Prefix or suffix would work great.

@arybczak
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant