-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unify the config syntax #18
Comments
red_green can be used instead of 2_3. Also, if you can list all the inconsistent stuff in more details it would be great. |
Then document it. This is the most important one Also the separator between the column names and the song list should have a colouring option and bolding too. Volume indicator needs boldness option. The Playing and [Paused] should be colored separately from the rest of the bar, as should the remaining time. I think that covers most of it. |
Then RTFM? It's written in the example configuration file:
This was already done. The problem with allowing other elements to be customizable (i.e. allowed to be bolded or not) is that if it's done naively, i.e. like with progressbar, it results in a shitton of configuration variables. And then someone will complain that there is no option for underline or reverse. That's why I'm thinking about changing the way the customization works for these parts, i.e. applying prefix/suffix formatting to them. This would solve all the possible problems. Any thoughts? |
I can't believe I missed that. Prefix or suffix would work great. |
This is pretty much done now, see https://github.com/arybczak/ncmpcpp/blob/51d7c9d7d51d79ed039b9f89bd5270f23e7b47e4/doc/config#L497. |
Some things can be bolded and others can't, some colors can be set with 2_5 etc. and others require color names and thus can't have different background color.
Things like columns playlist and volume need bolding from the top of my head.
The playlist also needs to use the new fg_bg notation.
Changing the notation to red_green instead of 2_3 would probably help many people understand it.
The text was updated successfully, but these errors were encountered: