Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display of unicode chars #21

Closed
vanishing opened this issue Jan 3, 2015 · 12 comments
Closed

Display of unicode chars #21

vanishing opened this issue Jan 3, 2015 · 12 comments

Comments

@vanishing
Copy link

Recently, not sure which commit, I found ncmpcpp displays unicode chars weirdly....
Like so:
recorded

@arybczak
Copy link
Collaborator

arybczak commented Jan 4, 2015

Does this happen with the current master? I know there was a bug like this, but I thought I fixed it.

@vanishing
Copy link
Author

Yes, this happens with the current master.
However, if I comment out the Reload part of update function in lyrics.cpp, this does not happen:

void Lyrics::update()
{
#   ifdef HAVE_CURL_CURL_H
    if (isReadyToTake)
        Take();

    if (isDownloadInProgress)
    {
        w.flush();
        w.refresh();
    }
#   endif // HAVE_CURL_CURL_H
    /* if (Reload)
    {
        drawHeader();
        itsScrollBegin = 0;
        Load();
        Reload = 0;
    }*/
}

What's weird is not only lyrics are doing this, but also the tags, however comment out the Reload part "fixes" them all.,,

@arybczak
Copy link
Collaborator

Can you give me the file with these lyrics? Also, does this happen only in lyrics screen or also in song info/artist info?

@arybczak
Copy link
Collaborator

Also, does this happen in all of your terminal emulators or only a specific one? If so, which one?

@vanishing
Copy link
Author

Sorry for replying late.
This happens in all my terminals, and this happens both in lyrics and tag editor, but not in playlists.
For the file with lyrics, it is easy to produce, you can find any mp3 file, rename it to a.mp3. Then create a.lrc with content"测试", play the file and check the lyrics.

@arybczak
Copy link
Collaborator

I don't get it. Check the lyrics with what? Can you just upload the lyrics and artist/title of the song to a pastebin?

@vanishing
Copy link
Author

Sure, the lyrics is at: http://paste.ubuntu.com/9859478/
The artist is: 周杰伦, or Jay Chou
The title is: 七里香

I think you can download it here: https://www.mp3days.net/download-songs/i_1K-LFOPi8/%E5%91%A8%E6%9D%B0%E4%BC%A6-%E4%B8%83%E9%87%8C%E9%A6%99-s.html
Click on "Download: 周杰伦 - 七里香 [LYRICS].mp3".

@arybczak
Copy link
Collaborator

This is rather puzzling, because it doesn't happen here. What version of ncurses do you use?

Also, can you try if this patch http://pastebin.com/fbwzhsD2 fixes the issue?

@vanishing
Copy link
Author

I can confirm the patch seems to fix the issue.

@arybczak
Copy link
Collaborator

What ncurses version do you use?

@vanishing
Copy link
Author

I've got:

»»»  apt-cache policy libncurses5
libncurses5:
  Installed: 5.9+20140712-2ubuntu1
  Candidate: 5.9+20140712-2ubuntu1
  Version table:
 *** 5.9+20140712-2ubuntu1 0
        500 http://archive.ubuntu.com/ubuntu/ vivid/main amd64 Packages
        100 /var/lib/dpkg/status

@arybczak
Copy link
Collaborator

Fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants