[#21] Use exit(1) as exit status code when printing `Usage: [...]` #22

iperdomo · 2018-05-21T11:03:51Z

If su-exec is used as part of an environment where exit codes are
used to signal errors. We can consider using wrong number of
arguments as an error, then we can use exit(1) for that.

- If su-exec is used as part of an environment where exit codes are used to signal errors. We can consider using wrong number of arguments as an error, then we can use exit(1) for that.

jakirkham · 2018-06-22T17:51:12Z

Could we at least allow a -h/--help option that doesn't fail then?

Edit: Also -v/--version would be nice to have not failing too.

iperdomo · 2018-06-25T03:43:19Z

@jakirkham in this case the print of Usage is because the number of arguments is wrong argc < 3 so I guess you're requesting a new feature. TBH I don't know if this PR will be merged, it was just my proposal for fixing a problem I faced.

michaelbaudino · 2021-12-19T20:55:54Z

su-exec.c

@@ -29,7 +29,7 @@ int main(int argc, char *argv[])

 	argv0 = argv[0];
 	if (argc < 3)
-		usage(0);
+		usage(1);


According to /usr/include/sysexits.h (Linux) / man 3 sysexits (*BSD), shouldn't we return 64 (EX_USAGE) here, to comply with POSIX standard?

EX_USAGE -- The command was used incorrectly, e.g., with the wrong number of arguments, a bad flag, a bad syntax in a parameter, or whatever.

@michaelbaudino thanks for the review. I'll update the PR

@michaelbaudino

Based on a review by @michaelbaudino > According to /usr/include/sysexits.h (Linux) / man 3 sysexits > (*BSD), shouldn't we return 64 (EX_USAGE) here, to comply with POSIX > standard?

[ncopa#21] Use one (1) as exit status code when printing Usage: [...]

fdc8a53

- If su-exec is used as part of an environment where exit codes are used to signal errors. We can consider using wrong number of arguments as an error, then we can use exit(1) for that.

michaelbaudino reviewed Dec 19, 2021

View reviewed changes

[ncopa#21] Use 64 (EX_USAGE) instead of 1 for signaling error

c66109f

Based on a review by @michaelbaudino > According to /usr/include/sysexits.h (Linux) / man 3 sysexits > (*BSD), shouldn't we return 64 (EX_USAGE) here, to comply with POSIX > standard?

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[#21] Use exit(1) as exit status code when printing `Usage: [...]` #22

[#21] Use exit(1) as exit status code when printing `Usage: [...]` #22

iperdomo commented May 21, 2018

jakirkham commented Jun 22, 2018 •

edited

Loading

iperdomo commented Jun 25, 2018

michaelbaudino Dec 19, 2021

iperdomo Dec 20, 2021

[#21] Use exit(1) as exit status code when printing Usage: [...] #22

Are you sure you want to change the base?

[#21] Use exit(1) as exit status code when printing Usage: [...] #22

Conversation

iperdomo commented May 21, 2018

jakirkham commented Jun 22, 2018 • edited Loading

iperdomo commented Jun 25, 2018

michaelbaudino Dec 19, 2021

Choose a reason for hiding this comment

iperdomo Dec 20, 2021

Choose a reason for hiding this comment

[#21] Use exit(1) as exit status code when printing `Usage: [...]` #22

[#21] Use exit(1) as exit status code when printing `Usage: [...]` #22

jakirkham commented Jun 22, 2018 •

edited

Loading