improve phpstan tests

composer.json

@@ -14,7 +14,8 @@
     },
     "require-dev": {
         "phpunit/phpunit": "^7.0",
-        "phpstan/phpstan": "^0.9.2"
+        "phpstan/phpstan": "^0.11.7",
+        "phpstan/phpstan-strict-rules": "^0.11"
     },
     "autoload": {
         "psr-4": {
@@ -30,7 +31,7 @@
             "@phpstan"
         ],
         "phpunit": "phpunit --colors=always",
-        "phpstan": "phpstan analyse src --level=7",
+        "phpstan": "phpstan analyze -l max -c phpstan.neon ./src",
         "test-coverage": "phpunit --coverage-clover clover.xml"
     },
     "minimum-stability": "dev",

phpstan.neon

@@ -0,0 +1,9 @@
+includes:
+    - vendor/phpstan/phpstan-strict-rules/rules.neon
+parameters:
+    fileExtensions:
+        - php
+    reportUnmatchedIgnoredErrors: true
+    ignoreErrors:
+        # @see src/Dispatcher
+        - '#PHPDoc tag @param for parameter \$middleware with type array\|string\|Zend\\Stratigility\\MiddlewarePipe is not subtype of native type array\<int, mixed\>#'

src/Dispatcher.php

@@ -4,13 +4,14 @@
 
 namespace Chiron\Pipe;
 
-use LogicException;
 use OutOfBoundsException;
+use UnexpectedValueException;
 use Psr\Http\Message\ResponseInterface;
 use Psr\Http\Message\ServerRequestInterface;
 use Psr\Http\Server\MiddlewareInterface;
 use Psr\Http\Server\RequestHandlerInterface;
 
+// TODO : renommer la classe en PipeHandler
 class Dispatcher implements RequestHandlerInterface
 {
     /**
@@ -52,7 +53,7 @@ public function handle(ServerRequestInterface $request): ResponseInterface
         $middleware = $this->middlewares[$this->index++];
 
         if (! $middleware instanceof MiddlewareInterface) {
-            throw new LogicException(sprintf(
+            throw new UnexpectedValueException(sprintf(
                 'Middleware "%s" is not an instance of %s',
                 is_object($middleware) ? get_class($middleware) : gettype($middleware),
                 MiddlewareInterface::class

tests/DispatcherTest.php

@@ -58,7 +58,7 @@ public function testDispatcherAcceptsASingleArgument()
     }
 
     /**
-     * @expectedException \LogicException
+     * @expectedException \UnexpectedValueException
      * @expectedExceptionMessage is not an instance of Psr\Http\Server\MiddlewareInterface
      */
     public function testDispatcherThrowExceptionForInvalidMultipleArguments()
@@ -73,7 +73,7 @@ public function testDispatcherThrowExceptionForInvalidMultipleArguments()
     }
 
     /**
-     * @expectedException \LogicException
+     * @expectedException \UnexpectedValueException
      * @expectedExceptionMessage is not an instance of Psr\Http\Server\MiddlewareInterface
      */
     public function testDispatcherThrowExceptionForInvalidSingleArrayArgument()
@@ -88,7 +88,7 @@ public function testDispatcherThrowExceptionForInvalidSingleArrayArgument()
     }
 
     /**
-     * @expectedException \LogicException
+     * @expectedException \UnexpectedValueException
      * @expectedExceptionMessage is not an instance of Psr\Http\Server\MiddlewareInterface
      */
     public function testDispatcherThrowExceptionForInvalidSingleArgument()