fix: gc error caused by calls of the GLib.Bytes.unref_to_array
#5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ncpa0cpl
force-pushed
the
fix/gc-error
branch
13 times, most recently
from
3b135a0
to
ae67312
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was discovered that calls of the
GLib.Bytes.unref_to_arraywere leaving the underlyingBytesobject in a state that was causing GC to fail when trying to free up the memory taken by it. All the instances where this function was used have been updated to use theGLib.Bytes.toArrayfunction instead, which should fix this issue.