Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump deps and fix tests #101

Merged
merged 5 commits into from
Jan 5, 2022
Merged

Conversation

andrelaszlo
Copy link
Contributor

Fixes #97
Fixes #63

@andrelaszlo
Copy link
Contributor Author

andrelaszlo commented Jan 5, 2022

@ncr Is this useful? Would like to use rack-proxy but we need those security patches first. :) I'm available to fix feedback on Friday and any time next week.

(Sorry for the force-pushes; I needed to get author/committer to match my key or Github wouldn't verify it properly.)

@andrelaszlo andrelaszlo force-pushed the bump-deps-and-fix-tests branch 3 times, most recently from 30a0cda to abf7eaf Compare January 5, 2022 19:25
Use mockapi.io (just googled something neutral) instead of the hosts currently used.
HTTP headers are case insensitive, but `Rack::MockResponse` is calling
`headers.fetch` which isn't case insensitive even when `headers` is a
`Utils::HeaderHash` instance. The easiest solution seemed to be to
just change our normalized header format to whatever
`Rack::MockResponse` expects.
@ncr
Copy link
Owner

ncr commented Jan 5, 2022

Hello @andrelaszlo, thank you for this contribution. I will merge it and release a new version shortly :)

@ncr ncr merged commit 9d0465c into ncr:master Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants