Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activate the coverage badge #237

Merged
merged 1 commit into from
Oct 30, 2018
Merged

Activate the coverage badge #237

merged 1 commit into from
Oct 30, 2018

Conversation

dhruvhacks
Copy link
Member

@dhruvhacks dhruvhacks commented Jul 8, 2018

This PR adds the coverage badge by updating the README.md

fixes #236

@RishabhJain2018 Please review this PR. 馃檪

@RishabhJain2018
Copy link
Member

@dhruvhacks It doesn't make any difference, see screenshot below.
screenshot 2018-10-30 at 5 50 13 pm

@dhruvhacks dhruvhacks force-pushed the coverage_badge branch 2 times, most recently from 0783089 to 8e3ac36 Compare October 30, 2018 21:57
@dhruvhacks
Copy link
Member Author

dhruvhacks commented Oct 30, 2018

@RishabhJain2018
Sir, Coverage was setup to check master branch only.
Hence it remains unknown for this branch.

@dhruvhacks
Copy link
Member Author

@RishabhJain2018
Sir,
As per the current settings, branch coverage is disabled.
So should I update this setting?
Or allow its check for master branch only as it was?

Updated coverage badge API.

closes #236
@RishabhJain2018
Copy link
Member

Yeah you can update the settings to allow for branch.

@dhruvhacks dhruvhacks merged commit 3e8fa9b into master Oct 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Coverage badge shows unknown coverage
2 participants