Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

groups seeded #257

Merged
merged 4 commits into from Aug 16, 2020
Merged

groups seeded #257

merged 4 commits into from Aug 16, 2020

Conversation

Mansi145
Copy link
Contributor

fixes #198

@dhruvhacks dhruvhacks added this to In progress in HTTP_200 Migration via automation Aug 11, 2020
HTTP_200 Migration automation moved this from In progress to Review in progress Aug 11, 2020
Copy link
Member

@dhruvhacks dhruvhacks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Mansi145 Just tested createdata command and realized that it does create the required groups but with some dummy users and notices which must be optional IMO. We'll have an additional task to selectively remove the dummy data if this project is deployed again.

You may either shit this change in a new command (say creategroups) or add argument parsers to this one (say python manage.py createdata --withdummy). Point is to keep the creation of dummy users and notices as an option for developer/tester.

@Mansi145
Copy link
Contributor Author

@dhruvhacks sir, please review the changes. The command will go by python manage.py createdata --dummydata. Should I add the required changes in the readme.md?

Copy link
Member

@dhruvhacks dhruvhacks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should I add the required changes in the readme.md?

@Mansi145 Sure!
Also, this PR encountered a build failure, do resolve that.
Check TravisCI

$ flake8 ./
./apps/profiles/management/commands/createdata.py:40:41: E128 continuation line under-indented for visual indent
./apps/profiles/management/commands/createdata.py:41:57: E127 continuation line over-indented for visual indent
./apps/profiles/management/commands/createdata.py:44:57: E124 closing bracket does not match visual indentation
./apps/profiles/management/commands/createdata.py:47:49: E128 continuation line under-indented for visual indent
./apps/profiles/management/commands/createdata.py:53:29: E128 continuation line under-indented for visual indent
./apps/profiles/management/commands/createdata.py:54:29: E128 continuation line under-indented for visual indent
./apps/profiles/management/commands/createdata.py:55:29: E128 continuation line under-indented for visual indent
./apps/profiles/management/commands/createdata.py:61:45: E128 continuation line under-indented for visual indent
./apps/profiles/management/commands/createdata.py:73:53: E128 continuation line under-indented for visual indent
./apps/profiles/management/commands/createdata.py:85:53: E128 continuation line under-indented for visual indent

The command "flake8 ./" exited with 1.

HTTP_200 Migration automation moved this from Review in progress to Reviewer approved Aug 16, 2020
@dhruvhacks dhruvhacks merged commit abf8f23 into ncs-jss:master Aug 16, 2020
HTTP_200 Migration automation moved this from Reviewer approved to Done Aug 16, 2020
singhsourabh pushed a commit to singhsourabh/HTTP_200 that referenced this pull request Aug 20, 2020
This PR includes commits that
* seeds groups
* creates dummy-data
* updates readme.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

Add faker to seed the initial database.
2 participants