Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix code sniffer errors #5

Merged
merged 2 commits into from Oct 1, 2017
Merged

Conversation

christophherr
Copy link
Contributor

Warnings about "Line exceeding 85 characters" are still being shown.
Related issue: #4

@coveralls
Copy link

Coverage Status

Coverage remained the same at 2.268% when pulling 3b4b819 on christophherr:master into 343fc91 on ncs-jss:master.

@christophherr
Copy link
Contributor Author

The three options would be to try to reduce the characters per line, exclude the line length rule or add your own line length standard.

@ankitjain28may
Copy link
Contributor

@christophherr It can also be fixed like you can break line from commas or you can use . to concat a large statement by breaking it into smaller sub strings.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.02%) to 2.248% when pulling 7f9be90 on christophherr:master into 343fc91 on ncs-jss:master.

@christophherr
Copy link
Contributor Author

christophherr commented Oct 1, 2017

@ankitjain28may No problem. Just wanted to know how you want to handle it.
Of course, now that there are more lines, the coverage has decreased and that fails the build...

@ankitjain28may
Copy link
Contributor

@christophherr No problem, Thanks for fixing this, Would you like to write the tests for the project ?

@ankitjain28may ankitjain28may merged commit 1ea308b into ncs-jss:master Oct 1, 2017
@christophherr
Copy link
Contributor Author

@ankitjain28may Thanks. I'll see if I can add some tests.

@ankitjain28may
Copy link
Contributor

@christophherr You can use Laravel/dusk to write tests for the project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants