remove implicit conversion to SPDF with unit length j-index #125 #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in interval [z1,z2]" aggregation method for hz data
|
OK, in principle I like this idea: converting to a different class object should always be explicit. The original idea was perhaps more clever than its own good. I'm fine with this as long as we spend a little more time checking for potential bugs. I doubt anyone actually used this feature. I'll need a little more time to review the SPC tutorial and manual pages. |
|
Is there anything I can do to move this PR along? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to remove inconsistency in behavior of j-index subsetting with index of unit length for Spatial and non-Spatial SPCs
2nd commit: exploits the new stable behavior of single-horizon SPC results from j-index subsetting to implement a "modality" argument to manipulate
glom()result