Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from JWT to Server-to-Server OAuth before June 2023 #387

Closed
jrchamp opened this issue Jun 2, 2022 · 6 comments · Fixed by #403
Closed

Switch from JWT to Server-to-Server OAuth before June 2023 #387

jrchamp opened this issue Jun 2, 2022 · 6 comments · Fixed by #403
Labels
enhancement Adds new functionality
Projects

Comments

@jrchamp
Copy link
Collaborator

jrchamp commented Jun 2, 2022

My summary of https://marketplace.zoom.us/docs/guides/build/jwt-app/jwt-faq/

  • JWT is going away June 2023
  • Zoom created Server-to-Server OAuth as a replacement

Overall, we'll want to have a version that uses Server-to-Server OAuth by March 2023 or sooner so people have a chance to install and configure the updated integration. It would also be good to:

  • provide a mechanism for people to switch early
  • maintain the JWT integration until JWT stops working

We'll likely need a new field for each element required to have a fresh token and potentially leverage an OAuth library as needed. If an OAuth library is needed and Moodle already provides one, this may require an increase in our minimum supported Moodle version.

If anyone else has thoughts on this, please share.

@jrchamp jrchamp added the enhancement Adds new functionality label Jun 2, 2022
@jrchamp jrchamp added this to To Do in Issues Jun 9, 2022
@jrchamp
Copy link
Collaborator Author

jrchamp commented Jun 9, 2022

Beyond the technical requirements, a communication plan would be valuable for Moodle administrators. The Zoom administrator may be in an entirely separate part of the organization and will need to get the new app type configured.

The release that includes this functionality should:

  • Highlight the new authentication option in the release notes and prioritize it over the legacy JWT option in the settings.
  • Provide a reference to Zoom's JWT deprecation documentation.
  • If there is an appropriate method, notify Moodle administrators that are using the legacy JWT option.

@mhughes2k
Copy link
Contributor

Just going to leave https://docs.moodle.org/400/en/OAuth_2_services here as it looks like it may be feasible to use Moodle's Oauth 2 services to define how to connect to Zoom

@jrchamp jrchamp moved this from To Do to Has Pull Request in Issues Sep 15, 2022
@sgrandh3
Copy link
Collaborator

Testing completed, no issues found. Verified the basic functionality and the scheduled tasks.

jrchamp added a commit that referenced this issue Sep 29, 2022
Issues automation moved this from Has Pull Request to Done Sep 29, 2022
@phette23
Copy link

phette23 commented Oct 5, 2022

What does configuring this look like on the Zoom end? I started created a server-to-server OAuth app but when I got to the step where you add scopes I wasn't sure what to do. What scopes does this need? Is there plan to write up a wiki page or something on what it looks like to switch to OAuth? No rush obviously I just want to be prepared.

@haietza
Copy link
Contributor

haietza commented Oct 6, 2022

@phette23 The README.md has information about scopes and a link to the Zoom documentation for creating a server-to-server OAuth app.

@phette23
Copy link

phette23 commented Oct 6, 2022

@haietza oops, my apologies. I read the issue, looked at the wiki, but didn't think to check if the readme was updated. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Adds new functionality
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

5 participants