Adapt mobile app code to Ionic 5 #269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Someone with permissions should link this PR to the issue: #242 |
|
Hey Dani, Thanks for working on this. I'll work on testing this in our test environment. |
|
I've tested this the best way I know how. Everything looks to be working well. |
smbader
approved these changes
Jun 29, 2021
|
Thank you @dpalou! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, this PR is to adapt the mobile app code to Ionic 5. I wasn't able to test this code because I don't have an API key and I don't have enough time to configure this properly, it would be great if you could verify that it works as expected. The template has barely changed so it I think it should work fine.
Fixes #242