Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

exists_on_zoom: Update during recreate and meeting-not-found #273

Merged
merged 1 commit into from
Jul 1, 2021
Merged

exists_on_zoom: Update during recreate and meeting-not-found #273

merged 1 commit into from
Jul 1, 2021

Conversation

jrchamp
Copy link
Collaborator

@jrchamp jrchamp commented Jun 29, 2021

  • On recreate, set ZOOM_MEETING_EXISTS and update the time.
  • On view, if we already know it's expired, show the recreate message.
  • On view, if the API lets us know that the meeting no longer exists, mark as ZOOM_MEETING_EXPIRED.

Fixes #271
Fixes #272

Note: In #272, @abias mentions the update_meetings task. The only meetings that are processed are the ones that are already set to ZOOM_MEETING_EXISTS, so we should not need to set ZOOM_MEETING_EXISTS.

@jrchamp jrchamp added the bug Fixes problems or reduces technical debt label Jun 29, 2021
@jrchamp jrchamp requested a review from a team June 29, 2021 18:45
@jrchamp jrchamp self-assigned this Jun 29, 2021
@smbader smbader merged commit 69bcb47 into master Jul 1, 2021
@smbader smbader deleted the fix/exists_on_zoom_updates branch July 1, 2021 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smbader smbader smbader approved these changes

Assignees

@jrchamp jrchamp

Labels
bug Fixes problems or reduces technical debt
Projects
None yet
Milestone
No milestone
2 participants
@jrchamp @smbader