Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable mustache ci and comment mustache files #276

Merged
merged 3 commits into from
Jul 1, 2021

Conversation

smbader
Copy link
Contributor

@smbader smbader commented Jun 30, 2021

Turn on mustache ci actions and add missing comments from mustache files.

Copy link
Collaborator

@jrchamp jrchamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like an improvement overall. Maybe HQ has some ideas?

.github/workflows/ci.yml Show resolved Hide resolved
templates/mobile_view_page_ionic3.mustache Outdated Show resolved Hide resolved
templates/mobile_view_page_latest.mustache Outdated Show resolved Hide resolved
Copy link
Collaborator

@jrchamp jrchamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than some extraneous warnings from the HTML validator, this passed the tests and improved the template documentation. Thanks!

@smbader smbader merged commit 0e0dc77 into ncstate-delta:master Jul 1, 2021
@smbader smbader deleted the enable-mustacheci branch July 7, 2021 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants