Issue281 - New activity setting: Automatic Recording

[aduranterres]

Resolves #281

[jrchamp]

I know you're still working on this, so I only did a brief check to see if I could understand the code.

[jrchamp]

@aduranterres I rebased the code and rebuilt the JavaScript files with grunt amd. Please make sure I didn't break anything, because the initial rebase lost the JavaScript files...

[aduranterres]

Hi @jrchamp Thank you very much for all the code cleaning you did, sorry about the unchanged headers, etc.

I have uploaded some new changes:

• Don't use form reload if allowrecordingchangeoption is not enabled in Zoom settings, as it is not needed
• Don't do anything on definition_after_data if allowrecordingchangeoption is not enabled, as the field option_auto_recording does not exist (it was throwing an error if you disable allowrecordingchangeoption)

The function definition_after_data is always executed after the form first loads, so that's why the second modification was needed.

I see now that grunt is complaining again...I am not sure why as I have not changed them after I got your changes or run grunt again, so sorry for giving you more work.

[jrchamp]

I was able to get a few minutes to apply your changes and I'm fairly sure that I have them all this time. 😄

@sgrandh3 Thank you for offering to test this. You will probably need one or two people to grant you scheduling privilege, so let me know and I'll grant you access.

[jrchamp]

Adding some comments about dynamic class properties and adjusting some admin-level setting defaults.

[jrchamp]

The testing revealed a minor issues string issues that were easily addressed. Approving and merging. We'll plan to release this next week, hopefully with a performance improvement PR #401.