Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

external: add missing use statements #554

Merged
merged 1 commit into from
Dec 14, 2023
Merged

external: add missing use statements #554

merged 1 commit into from
Dec 14, 2023

Conversation

jrchamp
Copy link
Collaborator

@jrchamp jrchamp commented Dec 13, 2023

Thanks to ramprakash k for letting us know about the issue.

@jrchamp jrchamp added the bug Fixes problems or reduces technical debt label Dec 13, 2023
@jrchamp jrchamp requested a review from a team December 13, 2023 16:16
@jrchamp jrchamp self-assigned this Dec 13, 2023
@smbader smbader added this to Needs review in Pull Requests Dec 14, 2023
@smbader smbader requested review from smbader and removed request for a team December 14, 2023 16:22
@smbader smbader moved this from Needs review to Testing needed in Pull Requests Dec 14, 2023
smbader
smbader approved these changes Dec 14, 2023
View reviewed changes
Copy link
Contributor

@smbader smbader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The two changes provided here are needed rather urgently.

Pull Requests automation moved this from Testing needed to Approved Dec 14, 2023
@smbader smbader merged commit afe8526 into ncstate-delta:main Dec 14, 2023
7 checks passed
Pull Requests automation moved this from Approved to Done Dec 14, 2023
@jrchamp jrchamp deleted the fix/mobile-context-module branch December 14, 2023 17:04
@jrchamp jrchamp mentioned this pull request Jan 19, 2024
Closed
@jrchamp jrchamp linked an issue Jan 19, 2024 that may be closed by this pull request
Class "mod_zoom\context_module" not found error on Moodle Mobile #566
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smbader smbader smbader approved these changes

Assignees

@jrchamp jrchamp

Labels
bug Fixes problems or reduces technical debt
Projects
Pull Requests
Archived in project
Pull Requests
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Class "mod_zoom\context_module" not found error on Moodle Mobile
2 participants
@jrchamp @smbader