feat: allow changing the scroll strategy #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willshowell
commented
Oct 20, 2017
| default: | ||
| config.scrollStrategy = this._overlay.scrollStrategies.noop(); | ||
| break; | ||
| } |
There was a problem hiding this comment.
Maybe use a separate method
config.scrollStrategy = this._getScrollStrategyInstance(this.attachedPopover.scrollStrategy);
private _getScrollStrategyInstance(s): ScrollStrategy {
switch (s) { ... }
}
src/lib/popover/popover.errors.ts
Outdated
| return Error(generateGenericError('scrollStrategy', strategy, VALID_SCROLL)); | ||
| } | ||
|
|
||
| function generateGenericError(apiName: string, invalid: string, valid: string[]): string { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20
At the moment, there seems to be something weird with the CloseScrollStrategy. I'm either using it wrong, or it isn't properly detaching. Removed from the possible options for now and tracking at angular/components#7922.