Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use '$stateChangeSuccess' to avoid $watch #6

Closed
wants to merge 1 commit into from

Conversation

tlvince
Copy link
Contributor

@tlvince tlvince commented Feb 20, 2014

No description provided.

@ncuillery
Copy link
Owner

Very glad to see this project start living. I was busy since the too old last commit but I will have time soon to examine issues/PR.

Thanks

@tlvince
Copy link
Contributor Author

tlvince commented Feb 25, 2014

No worries.

I started an alternative approach based on walking a state's $parent property in tv-breadcrumbs. I've also since found https://github.com/interval-braining/angular-ui-router-breadcrumbs by @tdg5

@ncuillery
Copy link
Owner

I've done some works about angular expressions in ncyBreadcrumbLabel. I tried to use $stateChangeSuccess to get a $scope but I encountered difficulties (see > angular-ui/ui-router/issues/1005).

For the moment, I use an other ui-router event : $viewContentLoaded (maybe forever, I think it works better with multiple views state.

@ncuillery ncuillery closed this Apr 6, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants