Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for meteor packaging #86

Merged
merged 1 commit into from
Jan 4, 2016
Merged

Added support for meteor packaging #86

merged 1 commit into from
Jan 4, 2016

Conversation

dotansimha
Copy link
Contributor

Hi @ncuillery,

I'm a package maintainer for Meteor.js, a popular full-stack JavaScript framework.
I'm also a developer on angular-meteor, a library that let's you work with AngularJS on top of Meteor.

A lot of our users use angular-breadcrumb and it right now there is a separate package and Github repo that simply manually copies your distribution and publish it to Meteor.
This PR will allow you to directly publish updated versions of angular-breadcrumb as they become available. All you have to do is create an account at https://meteor.com/ (click SIGN IN, then Create account). After you've done that, please let me know the name of the account, and I'll add you as a maintainer to the "ncuillery" organization there.

I've already published the current version of the package on Atmosphere (Meteor's package directory). When you release new versions of angular-breadcrumb, you'll be able to publish them to Atmosphere by running make meteor.

Thanks & best regards,
Dotan

@coveralls
Copy link

Coverage Status

Coverage remained the same at 96.67% when pulling eefdca3 on dotansimha:master into ef73525 on ncuillery:master.

@ncuillery
Copy link
Owner

Hi,

Thank for facilititating the connection with the meteor ecosystem. The name of my account is nicolascuillery.

When everything will be ok, i'll try to release the 0.3.4

@ncuillery
Copy link
Owner

@dotansimha, please can you add my account nicolascuillery to the ncuillery organisation ?

Then we could close this PR and deploy the current version (some forks start to show up in atmosphere https://atmospherejs.com/?q=angular%20breadcrumb ).

@dotansimha
Copy link
Contributor Author

@ncuillery , sure, done!

@dotansimha dotansimha closed this Dec 25, 2015
@ncuillery ncuillery reopened this Dec 25, 2015
ncuillery added a commit that referenced this pull request Jan 4, 2016
Added support for meteor packaging
@ncuillery ncuillery merged commit c3730f9 into ncuillery:master Jan 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants