Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement link sharing for all remotes that support it #2178

Open
14 of 24 tasks
breunigs opened this issue Mar 24, 2018 · 8 comments
Open
14 of 24 tasks

implement link sharing for all remotes that support it #2178

breunigs opened this issue Mar 24, 2018 · 8 comments

Comments

@breunigs
Copy link
Collaborator

breunigs commented Mar 24, 2018

in #2176 link sharing support was added for some remotes. This is a tracking ticket to add it for all other remotes that support it:

checkmark means that this remote was considered. If it's strike-through, then the remote cannot support it.

EDIT 2021: added Mailru, S3, B2, removed pcloud, ACD

@ncw ncw added this to the Soon milestone Mar 26, 2018
buengese added a commit to buengese/rclone that referenced this issue Aug 28, 2018
ncw pushed a commit that referenced this issue Sep 4, 2018
@theblackhole
Copy link

theblackhole commented Oct 4, 2018

This might help for Openstack Swift implementation :

From what I could understand, there are two types of urls :

jackyzy823 added a commit to jackyzy823/rclone that referenced this issue Oct 4, 2018
jackyzy823 added a commit to jackyzy823/rclone that referenced this issue Oct 4, 2018
jackyzy823 added a commit to jackyzy823/rclone that referenced this issue Oct 4, 2018
jackyzy823 added a commit to jackyzy823/rclone that referenced this issue Oct 4, 2018
jackyzy823 added a commit to jackyzy823/rclone that referenced this issue Oct 5, 2018
@ncw
Copy link
Member

ncw commented Oct 6, 2018

@theblackhole thanks for that. The first is probably what we want I think. Do you fancy making a pull request to implement?

@theblackhole
Copy link

@ncw Unfortunatly I don't know Golang but I may try when I got time.

Cnly pushed a commit that referenced this issue Oct 9, 2018
@xiaolei0125
Copy link

@ncw
This might help for implement link sharing for Amazon S3 Compliant Storage Providers (AWS, Ceph, Dreamhost, IBM COS, Minio, OSS):
s3_presigned_url.go

Using presigned url for link sharing, no matter the S3 bucket is private or public.
Notice: the presigned url needs to specify the expiration time.

I have test this presigned url code with Minio and OSS(S3 Compliant), all are work fine.
The presigned url look like this:
http://x.x.x.x:9000/mybucket/my.jpg?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Credential=CBDDBNRX5G91RTOM20K2%2F20181011%2Fus-east-1%2Fs3%2Faws4_request&X-Amz-Date=20181011T075806Z&X-Amz-Expires=900&X-Amz-SignedHeaders=host&X-Amz-Signature=d1c6835e991765c63ef64560f4f6e5b1c6679610a9791f2d5db70a9bbd51a25a

Is there a way to integrate presigned url into rclone link for Amazon S3 Compliant Storage Providers ?

Below is my code for reference:
s3_presigned_url.txt

@ncw
Copy link
Member

ncw commented Oct 14, 2018

@xiaolei0125 would you like to send a pull request for this?

If you implement the PublicLink optional method in the s3 backend with the code above that should be it!

For the time being put a really long expires on it and we can work out how to pass the desired expiry time in a second PR.

@xiaolei0125
Copy link

@ncw Ok, I've been a bit busy recently, I may try when I got time.

buengese added a commit to buengese/rclone that referenced this issue Nov 19, 2018
Get rid of the api client and use rest/pacer for all API calls
Add Copy, Move, DirMove, PublicLink, About optional interfaces
Improve general error handling
Remove ListR for now due to inconsitent behaviour
fixes rclone#2586, progress on rclone#2740 and rclone#2178
buengese added a commit to buengese/rclone that referenced this issue Nov 20, 2018
Get rid of the api client and use rest/pacer for all API calls
Add Copy, Move, DirMove, PublicLink, About optional interfaces
Improve general error handling
Remove ListR for now due to inconsitent behaviour
fixes rclone#2586, progress on rclone#2740 and rclone#2178
ncw pushed a commit that referenced this issue Nov 22, 2018
Get rid of the api client and use rest/pacer for all API calls
Add Copy, Move, DirMove, PublicLink, About optional interfaces
Improve general error handling
Remove ListR for now due to inconsitent behaviour
fixes #2586, progress on #2740 and #2178
poundifdef pushed a commit to poundifdef/rclone that referenced this issue Nov 27, 2018
Get rid of the api client and use rest/pacer for all API calls
Add Copy, Move, DirMove, PublicLink, About optional interfaces
Improve general error handling
Remove ListR for now due to inconsitent behaviour
fixes rclone#2586, progress on rclone#2740 and rclone#2178
yparitcher added a commit to yparitcher/rclone that referenced this issue Jun 30, 2019
yparitcher added a commit to yparitcher/rclone that referenced this issue Jun 30, 2019
yparitcher added a commit to yparitcher/rclone that referenced this issue Jun 30, 2019
yparitcher added a commit to yparitcher/rclone that referenced this issue Jul 1, 2019
yparitcher added a commit to yparitcher/rclone that referenced this issue Jul 1, 2019
yparitcher added a commit to yparitcher/rclone that referenced this issue Jul 2, 2019
yparitcher added a commit to yparitcher/rclone that referenced this issue Jul 3, 2019
ncw pushed a commit that referenced this issue Jul 3, 2019
@ivandeex
Copy link
Member

I stumbled upon this ticket paging through "least recently updated, not new backend, not from ncw", preferably labeled "help wanted" (aka "we are not going to take on this anytime soon"). Such tickets are mostly rot, rusted, non-reproducible and forgotten, but not this one. It's in fact a roadmap ticket. Marking as important to not forget.

Also I'd like to propose a column in https://rclone.org/overview/#features marking backends with public links. Maybe albertony or edwardxml would be kind to tackle? (Deliberately no mentions yet to reduce noise).

cc @ncw

@ncw
Copy link
Member

ncw commented Feb 12, 2021

@ivandeex wrote:

I stumbled upon this ticket paging through "least recently updated, not new backend, not from ncw", preferably labeled "help wanted" (aka "we are not going to take on this anytime soon"). Such tickets are mostly rot, rusted, non-reproducible and forgotten, but not this one. It's in fact a roadmap ticket. Marking as important to not forget.

I'm not sure which backends have the PublicLink feature... A quick grep comes up with this list

$ git grep -l PublicLink | sed 's/\/.*$//' | sort | uniq
b2
box
cache
chunker
compress
crypt
drive
dropbox
jottacloud
koofr
mailru
mega
onedrive
pcloud
premiumizeme
s3
seafile
sugarsync
yandex

pcloud wasn't on the list as done. I'm going to cross off Amazon Cloud Drive as that backend is frozen since we don't have an integration test and aren't welcome anyway!

Also I'd like to propose a column in https://rclone.org/overview/#features marking backends with public links. Maybe albertony or edwardxml would be kind to tackle? (Deliberately no mentions yet to reduce noise).

That sounds like a good plan, provided we don't overload the table!

Note that you can discover what features a backend has with rclone backend features MyRemote:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants