Add support for passing context to API calls #161
Comments
|
Yes this library could do with contexts! It was made well before contexts were first invented alas! I suggest we continue the discussion in #159 which is an existing issue about the same thing. It has some ideas as to what should be done - maybe you'll have a better one! Yes, I'd accept a PR for this :-) I'll close this issue - please head over to #159 :-) |
|
Oh great, I'll move there then. Thanks for info. :) |
Merged
2 tasks
ncw
added a commit
to rclone/rclone
that referenced
this issue
Jan 22, 2021
The update to v2 of the swift library introduces a context parameter to each function so required a lot of changes which were mostly mechanical. See: ncw/swift#161
ncw
added a commit
to rclone/rclone
that referenced
this issue
Feb 3, 2021
The update to v2 of the swift library introduces a context parameter to each function. This required a lot of mostly mechanical changes adding context parameters. See: ncw/swift#159 See: ncw/swift#161
negative0
pushed a commit
to negative0/rclone
that referenced
this issue
Aug 13, 2021
The update to v2 of the swift library introduces a context parameter to each function. This required a lot of mostly mechanical changes adding context parameters. See: ncw/swift#159 See: ncw/swift#161
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi, I have PR ready to be merged to the Thanos project to use your library for accessing Swift, but we are a bit concerned about lack of support for context cancellation. We use widely setting timeouts for the whole operations in the system and would be really handy if the library would be able to honor cancellation of the operations.
I'd be happy to send a PR if you would accept this feature and would agree on how it should be added.
Thanks for any info and your work on the library!
The text was updated successfully, but these errors were encountered: