Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement difficulty initialization and separate config/trainer #14

Merged
merged 2 commits into from
Jul 7, 2021
Merged

Implement difficulty initialization and separate config/trainer #14

merged 2 commits into from
Jul 7, 2021

Conversation

EntilZha
Copy link
Collaborator

@EntilZha EntilZha commented Jul 7, 2021

  1. Move out Dataset and related classes to their own file to avoid
    circular imports
  2. Factor out configuration from the trainer
  3. Implement a mechanism for initializing pyro param values
  4. Implement a way to initialize difficulty params to avoid sign
    ambiguity

@EntilZha
Merge a few changes together:
f0e7956 
1. Move out Dataset and related classes to their own file to avoid
   circular imports
2. Factor out configuration from the trainer
3. Implement a mechanism for initializing pyro param values
4. Implement a way to initialize difficulty params to avoid sign
   ambiguity
@jplalor jplalor merged commit 42d33ee into nd-ball:master Jul 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jplalor jplalor jplalor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@EntilZha @jplalor