Fix undefined behaviour from unthrown error

ndevenish · Aug 15, 2023 · f796e4d · f796e4d
1 parent 8078741
commit f796e4d
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/newsfragments/XXX.bugfix b/newsfragments/XXX.bugfix
@@ -0,0 +1 @@
+Fix situation where a bad ``Beam.probe`` could cause undefined behaviour.
diff --git a/src/dxtbx/model/beam.h b/src/dxtbx/model/beam.h
@@ -319,7 +319,7 @@ namespace dxtbx { namespace model {
       case neutron:
         return std::string("neutron");
       default:
-        DXTBX_ERROR("Unknown probe type");
+        throw DXTBX_ERROR("Unknown probe type");
       }
     }
 
@@ -335,7 +335,7 @@ namespace dxtbx { namespace model {
         return Probe::neutron;
       }
 
-      DXTBX_ERROR("Unknown probe " + probe);
+      throw DXTBX_ERROR("Unknown probe " + probe);
     }
 
     void set_probe(Probe probe) {