Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undocumented PHP Dependency #81

Closed
hexane360 opened this issue Sep 9, 2017 · 2 comments
Closed

Undocumented PHP Dependency #81

hexane360 opened this issue Sep 9, 2017 · 2 comments

Comments

@hexane360
Copy link
Contributor

Compiling/building 'libsyscalls' requires PHP to be installed. However, this dependency isn't listed in the installation guide: https://github.com/ndless-nspire/Ndless/wiki/Ndless-SDK:-C-and-assembly-development-introduction#On_Linux_distros

@Vogtinator
Copy link
Contributor

I'll actually fix that a different way, by removing stubs.cpp from the .gitignore. That way php won't be necessary anymore. The Makefile should take care of keeping it up-to-date, so nothing should break.

@hexane360
Copy link
Contributor Author

We should also probably remove stubs.cpp from the 'clean' recipe then, if it's not created by a normal build.

hexane360 added a commit to hexane360/Ndless that referenced this issue Sep 9, 2017
Removes 'stubs.cpp' from libsyscall's clean recipe, so it doesn't have to be recreated during a normal build. Fixes ndless-nspire#81
hexane360 added a commit to hexane360/Ndless that referenced this issue Sep 9, 2017
Removes 'stubs.cpp' and 'syscall-decls.h' from libsyscall's clean recipe, so it doesn't have to be recreated during a normal build. Fixes ndless-nspire#81
FrostyPenguin pushed a commit to FrostyPenguin/Ndless that referenced this issue Nov 4, 2017
- Once mkStubs.php or syscall-list.h change, it will be regenerated
- Fixes ndless-nspire#81
FrostyPenguin pushed a commit to FrostyPenguin/Ndless that referenced this issue Nov 4, 2017
Removes 'stubs.cpp' and 'syscall-decls.h' from libsyscall's clean recipe, so it doesn't have to be recreated during a normal build. Fixes ndless-nspire#81
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants