Some newlib-related optimizations #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids two issues: - init_signal unconditionally pulls in and calls malloc, even if signals aren't used - The allocated memory is (intentionally) never freed It appears like functions depending on init_signal call it themselves if it wasn't done previously, so this avoids both issues, as long as signal functions aren't used in the program.
- Without this, memory allocated by e.g. dtoa would not get freed - Have to set _impure_ptr to NULL to avoid if(ptr == _inpure_ptr) return; in _reclaim_reent
Merged
Like for newlib, libstdc++ also needs some code for cleaning up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Smaller binaries, less memory leaks.