Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add subexpressions #1

Closed
ndmitchell opened this issue Dec 17, 2017 · 4 comments
Closed

Add subexpressions #1

ndmitchell opened this issue Dec 17, 2017 · 4 comments
Labels
good first issue

Comments

@ndmitchell
Copy link
Owner

If you call a function whose results are not otherwise immediately available they should be added as a separate expression. e.g. if you have: foo x y = bar x y + foo y z then it would be useful to have dedicated values for bar x y and foo y z than than just $result.
@marklnichols
Copy link
Contributor

I'm starting to work on this one...

@marklnichols
Copy link
Contributor

Just checking in... I'm hoping to have a PR later today or maybe tomorrow. It mostly works now, I'm just cleaning up a few edge cases.

@marklnichols
Copy link
Contributor

This is hopefully done now, but I'll leave this open until its merged.

ndmitchell pushed a commit that referenced this issue Jan 21, 2018
@marklnichols
Merge pull request #1 from ndmitchell/master
f5931cb 
Updated fork
@ndmitchell
Copy link
Owner Author

Everything merged, so closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ndmitchell @marklnichols